This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Introduce ext_println to contract runtime
#2239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we make it command line flag to and have |
|
@xlc this is already done. |
bkchr
approved these changes
Apr 10, 2019
|
I mean can we add a flag like This way how this currently implemented won't work with node-template unless you modify https://github.com/paritytech/substrate/blob/master/node-template/src/chain_spec.rs as well. |
Robbepop
approved these changes
Apr 10, 2019
pepyakin
reviewed
Apr 10, 2019
ascjones
added
A8-looksgood
and removed
A0-please_review
shawntabrizi
approved these changes
Apr 11, 2019
ascjones
added a commit
that referenced
this pull request
Apr 11, 2019
* Implement `ext_println` in contract runtime * Only allow contracts to import `ext_println` on dev chains * Configure dev chain to allow contracts with `ext_println` * Increment spec version * Docs * Rename config to the more specific enable_println
bkchr
pushed a commit
that referenced
this pull request
Apr 11, 2019
* Implement `ext_println` in contract runtime * Only allow contracts to import `ext_println` on dev chains * Configure dev chain to allow contracts with `ext_println` * Increment spec version * Docs * Rename config to the more specific enable_println
MTDK1
pushed a commit
to bdevux/substrate
that referenced
this pull request
Apr 12, 2019
* Implement `ext_println` in contract runtime * Only allow contracts to import `ext_println` on dev chains * Configure dev chain to allow contracts with `ext_println` * Increment spec version * Docs * Rename config to the more specific enable_println
cmichi
pushed a commit
that referenced
this pull request
Apr 13, 2019
* Implement `ext_println` in contract runtime * Only allow contracts to import `ext_println` on dev chains * Configure dev chain to allow contracts with `ext_println` * Increment spec version * Docs * Rename config to the more specific enable_println
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rel: use-ink/ink#20
Introduces the
ext_printlnfunction which can be imported by smart contracts and used for debugging.There was some discussion with @pepyakin and @Robbepop about whether any debugging code should be allowed in the runtime at all, with the preferred long term solution being Diagnostic Runtimes.
However that is an
epictask, and we agreed that in the interest of improving the smart contract debugging experience in the short term (in time for Sub0) we should introduce the simpleext_println.This MUST be used on dev chains only. Contracts which import
ext_printlnwill be rejected when deployed to a chain with contract debugging disabled.