This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Can now disable the keystore #3004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavofyork
approved these changes
Jul 3, 2019
gavofyork
added
A6-seemsok
and removed
A0-please_review
bkchr
approved these changes
Jul 3, 2019
| info!("Generated a new keypair: {:?}", public_key); | ||
|
|
||
| public_key | ||
| if let Some(keystore) = keystore.as_mut() { |
There was a problem hiding this comment.
I think putting let public_key = in front of the if is more idiomatic rust?
There was a problem hiding this comment.
This is extreme nit-picking, but I didn't do it this way because it makes it look like the primary objective of this block is to fetch the public key, while in reality it is to generate the key if there's none.
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com>
MTDK1
pushed a commit
to bdevux/substrate
that referenced
this pull request
Jul 10, 2019
* Can now disable the keystore * Fix service test * Apply suggestions from code review Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com> * Fix cli
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #2416, the keystore obviously cannot load a key from the disk.
This PR makes it possible to disable the keystore by passing
Noneforkeystore_path.The second change I made is change the configuration to take
PathBufinstead ofString. I have no idea why we were usingString, and it doesn't make sense to me.