This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Switch the telemetry to new futures #3100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkchr
approved these changes
Jul 11, 2019
| libp2p::core::transport::map::Map< | ||
| OptionalTransport<wasm_ext::ExtTransport>, | ||
| fn(wasm_ext::Connection, ConnectedPoint) -> StreamSink<wasm_ext::Connection> | ||
| libp2p::core::transport::map::Map< |
There was a problem hiding this comment.
The problem here is that I'm using libp2p in a way it wasn't really designed for, but theoretically I could add some utility that allows using a Box here instead.
There was a problem hiding this comment.
It is okay, probably more rust faults of not having impl Something.
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc #3099
The majority of the switch to new futures is straight-forward, but for the telemetry it is pretty much not straight-forward.
Since libp2p is using futures v0.1, and the telemetry has a wrapper that guarantees that one telemetry write equals one WebSocket frame, we need to have a compatibility shim.
After this PR, the API of
substrate-telemetryuses new futures.