This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Explicitly declare decl_storage! getters as functions #3870
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backwards-compatible (test included) convenience improvement for
decl_storage!
.Instead of declaring a field as
we can declare as
This makes it clear that a function is being declared, and also means that searches for
fn getter_name
don't come up empty when reading code and looking for definitions. I also ported over all our SRML modules to follow this pattern.