Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Fix a check for polkadot to work on forked repos. #4075

Closed
wants to merge 2 commits into from

Conversation

tomusdrw
Copy link
Contributor

We avoid referencing the actual substrate repo and rather reference a local filesystem.

@tomusdrw tomusdrw added the A0-please_review Pull request needs code review. label Nov 10, 2019
@tomusdrw tomusdrw requested a review from TriplEight November 10, 2019 15:01
Copy link
Contributor

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this. Comment is not particularly important. Will cherry-pick this to #3955 to check its working with forks.

.gitlab-ci.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@TriplEight TriplEight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing, looks less hacky now.
Now I need to see if it works on forked repo. @mxinden can you demonstrate please?

@mxinden
Copy link
Contributor

mxinden commented Nov 10, 2019

Closing in favor of #4078.

@mxinden mxinden closed this Nov 10, 2019
@bkchr bkchr deleted the td-fix-polkacheck branch November 10, 2019 17:31
@mxinden mxinden restored the td-fix-polkacheck branch November 10, 2019 17:34
@mxinden mxinden deleted the td-fix-polkacheck branch November 10, 2019 17:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants