This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
client: Introduce --sentry-nodes flag #4285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable operators to specify the public addresses of sentry nodes infront of a validator node so that the validator node can announce the sentry node addresses instead of its own public addresses on the DHT via the authority discovery module.
Limit line length to 100 instead of 120 characters.
|
Corresponding Polkadot pull request: paritytech/polkadot#648. |
gavofyork
approved these changes
Dec 3, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable operators to specify the public addresses of sentry nodes infront of a validator node so that the validator node can announce the sentry node addresses instead of its own public addresses on the DHT via the authority discovery module.
Commit structure
This pull request is based on #4274, thus it should only be merged after #4274. One can ignore the first two commits when reviewing this pull request.
Commit 3 (updating
.maintain/sentry-node/docker-compose.yml) and commit 5 (shortening line length to 100 instead of 120 char) should not need much review.Commit 4 (a5b5db7) is the core of this pull request.
Polkadot
Given that this changes the signature of
AuthorityDiscovery::new, it will break Polkadot. I will follow up with another pull request on github.com/pairtytech/polkadot.