Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

decl_error! document that the error needs to be registered #4366

Merged
merged 1 commit into from
Dec 11, 2019
Merged

decl_error! document that the error needs to be registered #4366

merged 1 commit into from
Dec 11, 2019

Conversation

bkchr
Copy link
Member

@bkchr bkchr commented Dec 11, 2019

No description provided.

@bkchr bkchr added A0-please_review Pull request needs code review. A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). I6-documentation Documentation needs fixing, improving or augmenting. labels Dec 11, 2019
shawntabrizi
shawntabrizi approved these changes Dec 11, 2019
View reviewed changes
Copy link
Member

@shawntabrizi shawntabrizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@bkchr bkchr merged commit 3d17cbd into master Dec 11, 2019
@bkchr bkchr deleted the bkchr-decl-error-docu branch December 11, 2019 19:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shawntabrizi shawntabrizi shawntabrizi approved these changes

@kianenigma kianenigma Awaiting requested review from kianenigma

@gui1117 gui1117 Awaiting requested review from gui1117

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). I6-documentation Documentation needs fixing, improving or augmenting.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bkchr @shawntabrizi