Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

The genesis block initialisation logic #53

Merged
merged 13 commits into from
Feb 5, 2018
Merged

The genesis block initialisation logic #53

merged 13 commits into from
Feb 5, 2018

Conversation

gavofyork
Copy link
Member

@gavofyork gavofyork commented Jan 31, 2018

TODO:

  • Digest population for block authoring.

@gavofyork gavofyork added the A3-in_progress Pull request is in progress. No review needed at this stage. label Jan 31, 2018
@gavofyork gavofyork added A0-please_review Pull request needs code review. and removed A3-in_progress Pull request is in progress. No review needed at this stage. labels Feb 3, 2018
@arkpar
Copy link
Member

arkpar commented Feb 4, 2018

Lots of println! in native code. Why not use logging macros instead?

Vec::new()
}

impl_stubs!(execute_block, execute_transaction);
/// Execute a given, serialised, transaction. Returns the empty vector.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Returns the header it seems

@@ -37,6 +37,18 @@ pub struct Header {
pub digest: Digest,
}

impl Header {
pub fn from_block_number(number: BlockNumber) -> Self {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for testing only, right? A doc comment would be ince

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not really - useful in general when testing transactions without a specific preconstructed block to execute them within. doc comment sure

@gavofyork gavofyork merged commit 8ee3c40 into master Feb 5, 2018
@gavofyork gavofyork deleted the gav-genesis branch February 5, 2018 13:03
iStrike7 referenced this pull request in gasp-xyz/substrate Aug 3, 2021
iStrike7 referenced this pull request in gasp-xyz/substrate Aug 3, 2021
liuchengxu pushed a commit to chainx-org/substrate that referenced this pull request Aug 23, 2021
* cxrml-support

* financialrecords

provide deposit/withdrawal function for log the record

* change tokenbalances function name

* change tokenbalances function rename

* financialrecords finish

* refactor tokenbalances and financialrecords

* tokenbalances: provide handle_fee
* financialrecords:
    * provide with_index/without_index
    * provide deposit/withdrawal fee
    * config

* test case finish

* comment for financialrecords module

* use space replace tab
helin6 pushed a commit to boolnetwork/substrate that referenced this pull request Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants