This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavofyork
added
the
A3-in_progress
Pull request is in progress. No review needed at this stage.
label
Jan 31, 2018
gavofyork
added
A0-please_review
Pull request needs code review.
and removed
A3-in_progress
Pull request is in progress. No review needed at this stage.
labels
Feb 3, 2018
Lots of |
arkpar
reviewed
Feb 4, 2018
wasm-runtime/polkadot/src/lib.rs
Outdated
Vec::new() | ||
} | ||
|
||
impl_stubs!(execute_block, execute_transaction); | ||
/// Execute a given, serialised, transaction. Returns the empty vector. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Returns the header it seems
arkpar
reviewed
Feb 4, 2018
@@ -37,6 +37,18 @@ pub struct Header { | |||
pub digest: Digest, | |||
} | |||
|
|||
impl Header { | |||
pub fn from_block_number(number: BlockNumber) -> Self { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is for testing only, right? A doc comment would be ince
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not really - useful in general when testing transactions without a specific preconstructed block to execute them within. doc comment sure
arkpar
approved these changes
Feb 5, 2018
iStrike7
referenced
this pull request
in gasp-xyz/substrate
Aug 3, 2021
liuchengxu
pushed a commit
to chainx-org/substrate
that referenced
this pull request
Aug 23, 2021
* cxrml-support * financialrecords provide deposit/withdrawal function for log the record * change tokenbalances function name * change tokenbalances function rename * financialrecords finish * refactor tokenbalances and financialrecords * tokenbalances: provide handle_fee * financialrecords: * provide with_index/without_index * provide deposit/withdrawal fee * config * test case finish * comment for financialrecords module * use space replace tab
helin6
pushed a commit
to boolnetwork/substrate
that referenced
this pull request
Jul 25, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: