This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Batch benchmarks together with * notation.
#5436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavofyork
added
A0-please_review
kianenigma
reviewed
Mar 27, 2020
| @@ -39,13 +50,13 @@ sp_api::decl_runtime_apis! { | |||
| pub trait Benchmark { | |||
| /// Dispatch the given benchmark. | |||
| fn dispatch_benchmark( | |||
| module: Vec<u8>, | |||
| extrinsic: Vec<u8>, | |||
| pallet: Vec<u8>, | |||
There was a problem hiding this comment.
Suggested change
| pallet: Vec<u8>, | |
| pallet: &[u8], |
Shouldn't these also use slice?
There was a problem hiding this comment.
These values from from structopt, so I think they will be Vecs.
shawntabrizi
approved these changes
Mar 28, 2020
There was a problem hiding this comment.
This is great! Tested locally and works well.
I made a PR #5445
Which iterates on this and does the following:
- Moves the macro to
frame_benchmarking - Updates the name from
pallet!toadd_benchmark! - Update the syntax and construction of the macro just a little bit to pass the non-local variables to the rust macro.
Its a little bit nasty, but imo not that bad.
- Adds some docs.
If you like it, please merge before committing. Else, this is good as is too.
shawntabrizi
added
A8-mergeoncegreen
and removed
A0-please_review
* Move macro into `frame_benchmarking` * Update docs * Extra line * Return error if `batches` is empty
lamafab
pushed a commit
to lamafab/substrate
that referenced
this pull request
Jun 16, 2020
…aritytech#948) * Use `add_benchmark` macro * Return error if `batches` is empty * Update Cargo.lock * Companion for paritytech#5463 (paritytech#953) * Fix test with genesis block 0 * Update Cargo.lock
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
polkadot companion: paritytech/polkadot#948