This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
client/finality-grandpa: Instrument until-imported queue #5438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `UntilImported` queue takes as input finality grandpa messages that depend on blocks that are not yet imported and holds them back until those blocks are imported. This commit adds a basic metric, the amount of messages waiting in the queue, to the module. For now this metric is only available for the global `UntilImported` queue awaiting blocks for commit and catch-up messages.
mxinden
added
A0-please_review
expenses
approved these changes
Mar 27, 2020
Comment on lines
+89
to
+92
| // When a queue is dropped it might still contain messages. In order for those to not distort the | ||
| // Prometheus metrics, the `Metric` struct cleans up after itself within its `Drop` implementation | ||
| // by subtracting the local_waiting_messages (the amount of messages left in the queue about to | ||
| // be dropped) from the global_waiting_messages gauge. |
There was a problem hiding this comment.
Maybe a bit too clever. Hope to be able to get rid of this in the future.
Co-Authored-By: Ashley <ashley.ruglys@gmail.com>
|
Thanks for the quick review @expenses. |
andresilva
approved these changes
Mar 27, 2020
mxinden
added
A8-mergeoncegreen
and removed
A0-please_review
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
UntilImportedqueue takes as input finality grandpa messages thatdepend on blocks that are not yet imported and holds them back until
those blocks are imported.
This commit adds a basic metric, the amount of messages waiting in the
queue, to the module. For now this metric is only available for the
global
UntilImportedqueue awaiting blocks for commit and catch-upmessages.