This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Implements mocking of runtime apis #5448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pr adds support for easily mock runtime api implementations for tests by using the `mock_impl_runtime_apis!` macro. The syntax is similar to `impl_runtime_apis!`. The mocked implementation automatically implements `ApiExt`, `ApiErrorExt` and `Core` as these are required by the runtime api traits, but not required in tests or only a subset of them.
bkchr
added
A0-please_review
NikVolf
reviewed
Mar 30, 2020
NikVolf
reviewed
Mar 30, 2020
| let error = Error::new( | ||
| ty.span(), | ||
| "Error type can not change between runtime apis", | ||
| ); |
There was a problem hiding this comment.
FIY, you can combine syn errors so that original error_type that differs from this ty is highlighted as well
something like this:
let error = Error::new(
ty.span(),
"Error type can not change between runtime apis",
).combine(Error::new(error_type.span(), "First Error type declared here"));
NikVolf
reviewed
Mar 30, 2020
Co-Authored-By: Nikolay Volf <nikvolf@gmail.com>
NikVolf
approved these changes
Mar 31, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds support for easily mock runtime api implementations for
tests by using the
mock_impl_runtime_apis!macro. The syntax issimilar to
impl_runtime_apis!. The mocked implementation automaticallyimplements
ApiExt,ApiErrorExtandCoreas these are required bythe runtime api traits, but not required in tests or only a subset of them.
Closes: #1120
polkadot-companion: paritytech/polkadot#957