Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Service builder refactoring #5557

Closed
wants to merge 13 commits into from
Closed

Service builder refactoring #5557

wants to merge 13 commits into from

Conversation

cecton
Copy link
Contributor

@cecton cecton commented Apr 7, 2020

WIP for #4587

cecton added 12 commits April 7, 2020 12:13
@cecton
WIP
c79cc3a 
Forked at: 53e8ec2
Parent branch: origin/cecton-the-revenge-of-the-cli
@cecton
WIP
6569cdb 
Forked at: 53e8ec2
Parent branch: origin/cecton-the-revenge-of-the-cli
@cecton
WIP
dca7dee 
Forked at: 53e8ec2
Parent branch: origin/cecton-the-revenge-of-the-cli
@cecton
WIP
2a9d8e9 
Forked at: 53e8ec2
Parent branch: origin/cecton-the-revenge-of-the-cli
@cecton
WIP
e6ac588 
Forked at: 53e8ec2
Parent branch: origin/cecton-the-revenge-of-the-cli
@cecton
WIP
100cf8e 
Forked at: 53e8ec2
Parent branch: origin/cecton-the-revenge-of-the-cli
@cecton
WIP
cde5515 
Forked at: 53e8ec2
Parent branch: origin/cecton-the-revenge-of-the-cli
@cecton
WIP
d9e4471 
Forked at: 53e8ec2
Parent branch: origin/cecton-the-revenge-of-the-cli
@cecton
WIP
0663853 
Forked at: 53e8ec2
Parent branch: origin/cecton-the-revenge-of-the-cli
@cecton
Clean-up
9655f67
@cecton
Fix missing stuff
7d2848e
@cecton
Fix another missing stuff
c1031eb
@parity-cla-bot
Copy link

It looks like @cecton signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

@gavofyork gavofyork added the A3-in_progress Pull request is in progress. No review needed at this stage. label Apr 11, 2020
@NikVolf NikVolf mentioned this pull request Apr 16, 2020
Merged
@gnunicorn gnunicorn closed this Apr 17, 2020
@cecton cecton deleted the cecton-defer-service-builder-2 branch April 17, 2020 11:36
@cecton cecton restored the cecton-defer-service-builder-2 branch April 17, 2020 11:36
@NikVolf
Copy link
Contributor

NikVolf commented Apr 17, 2020

Why is this closed?

@gnunicorn
Copy link
Contributor

because the author is taking care of other things and won't continue this for now. the issue is still open and unassigned, so up for grabs :) .

@bkchr bkchr deleted the cecton-defer-service-builder-2 branch April 17, 2020 12:22
@cecton
Copy link
Contributor Author

cecton commented Apr 17, 2020

@bkchr maybe we should keep the branch for now as it can be useful for the chain ops part for the next person. Don't worry, I keep track of my branches it will be deleted at some point

@cecton cecton restored the cecton-defer-service-builder-2 branch April 17, 2020 13:33
@expenses
Copy link
Contributor

expenses commented Jun 8, 2020

I'm interested in taking over this PR!

@expenses expenses mentioned this pull request Jun 9, 2020
Closed
@cecton
Copy link
Contributor Author

cecton commented Jun 9, 2020

I delete my branch since it is not needed anymore. Thanks @expenses ❤️

@cecton cecton deleted the cecton-defer-service-builder-2 branch June 9, 2020 14:39
@expenses expenses mentioned this pull request Jul 2, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
A3-in_progress Pull request is in progress. No review needed at this stage.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cecton @parity-cla-bot @NikVolf @gnunicorn @expenses @gavofyork