This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Benchmarks for offences pallet. #5851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomusdrw
requested review from
andresilva,
Demi-Marie and
kianenigma
as code owners
tomusdrw
requested review from
marcio-diaz and
shawntabrizi
and removed request for
andresilva and
Demi-Marie
kianenigma
reviewed
Apr 30, 2020
kianenigma
reviewed
Apr 30, 2020
kianenigma
reviewed
Apr 30, 2020
kianenigma
reviewed
Apr 30, 2020
kianenigma
reviewed
Apr 30, 2020
kianenigma
reviewed
Apr 30, 2020
kianenigma
reviewed
Apr 30, 2020
kianenigma
reviewed
Apr 30, 2020
kianenigma
reviewed
Apr 30, 2020
kianenigma
approved these changes
Apr 30, 2020
…fences-benchmarks' into shawntabrizi-fix-offences-benchmarks
frame/balances/src/lib.rs
Outdated
| @@ -458,7 +458,7 @@ decl_module! { | |||
| /// - Contains a limited number of reads and writes. | |||
| /// # </weight> | |||
| #[weight = T::DbWeight::get().reads_writes(1, 1) + 100_000_000] | |||
| fn set_balance( | |||
| pub fn set_balance( | |||
There was a problem hiding this comment.
Just started reviewing, but you shouldn't need to make this pub. You can instead call make_free_balance_be which is part of the currency trait.
shawntabrizi
suggested changes
May 1, 2020
apopiak
reviewed
May 5, 2020
| @@ -18,7 +18,7 @@ | |||
| //! from VRF outputs and manages epoch transitions. | |||
|
|
|||
| #![cfg_attr(not(feature = "std"), no_std)] | |||
| #![forbid(unused_must_use, unsafe_code, unused_variables, unused_must_use)] | |||
| #![warn(unused_must_use, unsafe_code, unused_variables, unused_must_use)] | |||
There was a problem hiding this comment.
is this intentional (or a result of debugging)?
There was a problem hiding this comment.
Intentional. Using forbid may cause issues with:
- Quick development cycle
- Build randomly breaking on rustc upgrades
We did try that in the past, but it was doing more harm than good.
shawntabrizi
approved these changes
May 6, 2020
|
bot merge |
tomusdrw
added
A8-mergeoncegreen
and removed
A0-please_review
kianenigma
reviewed
May 6, 2020
| let raw_amount = bond_amount::<T>(); | ||
| // add twice as much balance to prevent the account from being killed. | ||
| let free_amount = raw_amount.saturating_mul(2.into()); | ||
| T::Currency::make_free_balance_be(&stash, free_amount); |
There was a problem hiding this comment.
just a note for whoever might read this in the future and want to work on benchmarks: we use this function quite a lot, and it does not change T::Currency::issuance. And we use total issuance in staking's phragmen, and it can cause some very hard to track bugs... so keep that in mind.
kianenigma
reviewed
May 6, 2020
kianenigma
approved these changes
May 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt to benchmark
offenceswith the same kind of reports that are most likely going to be used in the final runtime (likeim-online,grandpaandbabe).Even though we don't report
babe(see #5752) norgrandpa(see #3868) yet, the final report is not likely to change that much (or at all).