This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Update System Weights #5888
Merged
Update System Weights #5888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawntabrizi
commented
May 4, 2020
shawntabrizi
commented
May 4, 2020
shawntabrizi
commented
May 4, 2020
shawntabrizi
added
A3-in_progress
Co-authored-by: Alexander Popiak <alexander.popiak@parity.io>
This reverts commit 95bd276.
athei
reviewed
May 6, 2020
This is erroneous. There are instances where you may wish the Scheduler to be able to schedule a lower amount of weight than the block. It's quite reasonable, for instance, that you would only want to give 50% of the block over to (non-mandatory) scheduled tasks and leave the remainder for transactions. |
gavofyork
reviewed
May 6, 2020
gavofyork
reviewed
May 6, 2020
gui1117
reviewed
May 6, 2020
gui1117
reviewed
May 6, 2020
gui1117
reviewed
May 6, 2020
|
The weight is now updated using So I believe this can get any final reviews and green check-marks. |
shawntabrizi
commented
May 6, 2020
shawntabrizi
commented
May 6, 2020
athei
reviewed
May 7, 2020
athei
approved these changes
May 7, 2020
gavofyork
approved these changes
May 7, 2020
shawntabrizi
added
A8-mergeoncegreen
and removed
A0-please_review
|
bot merge |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the weights of FRAME System
Pretty straightforward, but we should be extra careful of the functions that use a full block (set_code and set_code_without_checks).
I would like to make sure there is no trivial mistake here that would prevent this extrinsic from entering a block. Does anyone see any issues?
Notable Changes:
kill_prefixto allow the Root user to tell us the number of subkeys under a prefix so that we may weight the function correctly. This parameter is not checked.sudo_unchecked_weightfunction, which ignores the weight of the dispatch call and instead uses any weight defined by the Sudo user. This can be helpful when trying to push a runtime upgrade where you dont have (or want) the scheduler.