This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Networking tests and fixes #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rphmeier
approved these changes
Feb 8, 2018
gavofyork
reviewed
Feb 8, 2018
substrate/client/src/lib.rs
Outdated
| @@ -176,7 +181,7 @@ impl<B, E> Client<B, E> where | |||
| blockchain::BlockStatus::Unknown => return Ok(ImportResult::UnknownParent), | |||
| } | |||
|
|
|||
| let mut transaction = self.backend.begin_transaction(BlockId::Number(header.number))?; | |||
| let mut transaction = self.backend.begin_transaction(BlockId::Number(header.number - 1))?; | |||
There was a problem hiding this comment.
header is the header being imported. The argument to begin_transaction is the base (parent) block id. Either hash or number.
There was a problem hiding this comment.
Changed it to parent_hash anyway
gavofyork
reviewed
Feb 8, 2018
| }; | ||
| edit_header(&mut header); | ||
|
|
||
| let mut tx = self.begin_transaction(BlockId::Hash(best_hash)).expect("In-memory backend does not fail"); |
There was a problem hiding this comment.
i can't see how this could possibly work in general - the polkadot runtime, at least, alters the state regardless of whether there are any transactions; the transaction_root must also be valid for blocks to be executed.
There was a problem hiding this comment.
This is for tests only. And since this is substrate client, the code that uses it should not care. I guess we could have more elaborate testing framework under /polkadot
gavofyork
approved these changes
Feb 8, 2018
JoshOrndorff
referenced
this pull request
in moonbeam-foundation/substrate
Apr 21, 2021
Crystalin add test workflow
iStrike7
referenced
this pull request
in gasp-xyz/substrate
Aug 3, 2021
iStrike7
referenced
this pull request
in gasp-xyz/substrate
Aug 3, 2021
liuchengxu
pushed a commit
to autonomys/substrate
that referenced
this pull request
Jun 3, 2022
…k-timeout Relayer fetch parablock timeout
imstar15
pushed a commit
to imstar15/substrate
that referenced
this pull request
Jan 3, 2023
…-info-rpc Feature/vesting info rpc
helin6
pushed a commit
to boolnetwork/substrate
that referenced
this pull request
Jul 25, 2023
* Do not error if type sizes missing: log warn * Split out EventsSubscriber, allow updating events decoder * Format code * Check missing type sizes after registration * Add example which for submit and watching events
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.