This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
5 random fixes (#2) #623
Merged
5 random fixes (#2) #623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepyakin
added
the
A2-insubstantial
|
the double-spaces are in legal text and (i think) there on purpose. |
gavofyork
reviewed
Aug 28, 2018
demo/runtime/src/lib.rs
Outdated
| @@ -8,11 +8,11 @@ | |||
|
|
|||
| // Substrate Demo is distributed in the hope that it will be useful, | |||
| // but WITHOUT ANY WARRANTY; without even the implied warranty of | |||
| // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | |||
| // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. ee the | |||
There was a problem hiding this comment.
It should have happened...
|
though there are a few correct removals of double-spacing |
|
Oh, nice to know, was wondering if that was on purpose! will revert the removal of the double spaces from the legal.
You mean, in the strings? |
pepyakin
force-pushed
the
ser-5-random-fixes-2
branch
from
9cbd625 to
1644588
Compare
|
Removed: 938706a |
dvdplm
approved these changes
Aug 29, 2018
gavofyork
approved these changes
Aug 29, 2018
gguoss
pushed a commit
to chainx-org/substrate
that referenced
this pull request
Sep 3, 2018
* Tabs instead of spaces.
* Remove double spaces.
* Add spaces between ID and the following {
* Update to nightly 2018-08-27
* Align wat code properly
dvdplm
added a commit
that referenced
this pull request
Sep 3, 2018
…rs-generic-over-hasher-and-rlpcodec * origin/master: (26 commits) Contract runtime polishing (#601) WIP on chain heap (#639) Events to track extrinsic success (#640) Install llvm-tools-preview component (#643) fix wasm executor compile error (#631) random fixes (#638) Empty becomes (), reflecting convention (#637) Allow to build_upon skipped entries, but don't walk back (#635) Separate out staking module into balances and payment (#629) Update .gitlab-ci.yml (#633) Do not attempt to rustup if in CI. This is taken care of by the base (#621) Avoid need for ident strings in storage (#624) rename to panic_handler as panic_implementation is deprecated in nightly (#626) 5 random fixes (#2) (#623) fix one typo in README (#627) Misspelled words (#625) Contracts: Per block gas limit (#506) Make sure to ban invalid transactions. (#615) (#620) Forward-port BFT fixes from v0.2 and restructure agreement cancelling (#619) Allow specifying listening multiaddresses (#577) ...
dvdplm
added a commit
that referenced
this pull request
Sep 4, 2018
* master: (22 commits) Introduce treasury and document (#646) Off-the-table staking preference (#656) Implement function `json_metadata` in `decl_module!` (#654) Fix warnings in networking (#652) Add a reputation system (#645) Check for pruned block state (#648) Contract runtime polishing (#601) WIP on chain heap (#639) Events to track extrinsic success (#640) Install llvm-tools-preview component (#643) fix wasm executor compile error (#631) random fixes (#638) Empty becomes (), reflecting convention (#637) Allow to build_upon skipped entries, but don't walk back (#635) Separate out staking module into balances and payment (#629) Update .gitlab-ci.yml (#633) Do not attempt to rustup if in CI. This is taken care of by the base (#621) Avoid need for ident strings in storage (#624) rename to panic_handler as panic_implementation is deprecated in nightly (#626) 5 random fixes (#2) (#623) ...
lamafab
pushed a commit
to lamafab/substrate
that referenced
this pull request
Jun 16, 2020
* Update to latest Substrate master (paritytech#615) * Update to latest Substrate master * Remove unneeded patch + warning * Update `Cargo.lock` * Fix tests * Update again * Bump Substrate (paritytech#616) * Update lock * Fix * Few fixes * Bump to latest Substrate * Fixes * fix pre-tx-pool compilation * more compilation fixes * Updates for the injection period - Liberal slash-refunding - Instant unbonding * *: Enable refactored authority discovery (paritytech#624) * *: Enable authority discovery module * *: List authority discovery id after parachain validator id Make sure existing key types don't change their order by appending the authority discovery id instead of injecting it between im online id and parachain validator id. * *: Gate authority discovery module behind feature flag * cli/src/lib.rs: Fix warnings * cli/src/lib.rs: Shorten line length * Bump Substrate * Bump Substrate * Line widths * Line widths again * Revert bump.
liuchengxu
pushed a commit
to chainx-org/substrate
that referenced
this pull request
Aug 23, 2021
* update substrate update substrate to 44d8a39 * support checksum for parse chainx addr
helin6
pushed a commit
to boolnetwork/substrate
that referenced
this pull request
Jul 25, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the spirit of #435
It is better to check each commit separately.