Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

update comment of runtime/impl.rs #6297

Closed
wants to merge 1 commit into from
Closed

update comment of runtime/impl.rs #6297

wants to merge 1 commit into from

Conversation

sekisamu
Copy link
Contributor

@sekisamu sekisamu commented Jun 9, 2020

according to the code in function convert, the formula should be:

some_value = (1 + (v * diff) + (v * diff)^2 / 2)
new_weight = old_weight + some_value (instead of multiplying it)

@parity-cla-bot
Copy link

It looks like @hammeWang signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

@gavofyork gavofyork added the A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). label Jun 9, 2020
@bkchr bkchr requested a review from kianenigma June 9, 2020 11:06
@bkchr bkchr added the B0-silent Changes should not be mentioned in any release notes label Jun 9, 2020
@kianenigma kianenigma added I6-documentation Documentation needs fixing, improving or augmenting. M3-docs labels Jun 9, 2020
@kianenigma
Copy link
Contributor

kianenigma commented Jun 9, 2020

This was reported a while ago and I have to look into it one more time. Indeed the research page of w3f and the implementation diverge a bit. Since the implementation was co-authored with someone else and was a long time ago, I prefer double checking it one more time. I am suspicious of our implementation being slightly wrong, in which case the comment is correct and the code needs fixing.

related:
#2854
darwinia-network/darwinia#447

I'll try to check it shortly, please don't merge/approve in the meantime.

@kianenigma kianenigma removed the I6-documentation Documentation needs fixing, improving or augmenting. label Jun 9, 2020
@kianenigma
Copy link
Contributor

Fixed here #6334

@kianenigma kianenigma closed this Jun 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants