This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavofyork
added
A3-in_progress
Pull request is in progress. No review needed at this stage.
B7-runtimenoteworthy
C1-low
PR touches the given topic and has a low impact on builders.
labels
Jul 30, 2020
github-actions
bot
added
A0-please_review
Pull request needs code review.
and removed
A3-in_progress
Pull request is in progress. No review needed at this stage.
labels
Jul 30, 2020
gavofyork
added
the
D9-needsaudit 👮
PR contains changes to fund-managing logic that should be properly reviewed and externally audited
label
Aug 3, 2020
gavofyork
commented
Aug 3, 2020
gavofyork
commented
Aug 3, 2020
shawntabrizi
reviewed
Aug 4, 2020
* update bechmarks to parameterize announcements * remove announcement param from proxy * Update pallet_proxy.rs * Update weights
shawntabrizi
approved these changes
Aug 4, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
shawntabrizi
reviewed
Aug 4, 2020
gavofyork
added
A8-mergeoncegreen
and removed
A0-please_review
Pull request needs code review.
A7-needspolkadotpr
D9-needsaudit 👮
PR contains changes to fund-managing logic that should be properly reviewed and externally audited
labels
Aug 21, 2020
bot merge |
Missing process info; check that the PR belongs to a project column. Merge can be attempted if:
|
gavofyork
added
A2-insubstantial
Pull request requires no code review (e.g., a sub-repository hash update).
and removed
A8-mergeoncegreen
labels
Aug 23, 2020
bot merge |
Waiting for commit status. |
Warning: This migration is missing a storage guard and will thus be executed more than once if included in more than one runtime upgrade. |
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A2-insubstantial
Pull request requires no code review (e.g., a sub-repository hash update).
C1-low
PR touches the given topic and has a low impact on builders.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows a proxy to be set so that the delegated account is required to announce (a hash of) their action some period before they can actually do it.
During this period, the proxied account can cancel the announcement and veto the action.
Combined with wallet software that alerts when these announcements are made, it should allow hot keys or warm keys to be used practically on relatively large sums of funds.
TODO:
polkadot companion: paritytech/polkadot#1520
cc @jacogr