Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

*: Update to next libp2p version 0.24.0 #6891

Merged
11 commits merged into from
Aug 21, 2020
Merged

*: Update to next libp2p version 0.24.0 #6891

11 commits merged into from
Aug 21, 2020

Conversation

mxinden
Copy link
Contributor

@mxinden mxinden commented Aug 14, 2020

For now here to test whether libp2p/rust-libp2p#1698 fixes paritytech/polkadot#1532.

Up until libp2p v0.24.0 is released this can serve as a place to collect necessary downstream changes.

Update libp2p to v0.24.0.

//CC @romanb @twittner @tomaka

@mxinden mxinden added A3-in_progress Pull request is in progress. No review needed at this stage. B3-apinoteworthy C1-low PR touches the given topic and has a low impact on builders. labels Aug 14, 2020
@github-actions github-actions bot added A0-please_review Pull request needs code review. and removed A3-in_progress Pull request is in progress. No review needed at this stage. labels Aug 14, 2020
@mxinden mxinden added A3-in_progress Pull request is in progress. No review needed at this stage. and removed A0-please_review Pull request needs code review. labels Aug 14, 2020
@mxinden mxinden changed the title *: Update to next libp2p version (likely v0.24.0) *: Update to next libp2p version 0.24.0 Aug 19, 2020
@mxinden mxinden added A0-please_review Pull request needs code review. A1-needs_burnin Pull request needs to be tested on a live validator node before merge. DevOps is notified via matrix B5-clientnoteworthy and removed A3-in_progress Pull request is in progress. No review needed at this stage. labels Aug 19, 2020
@mxinden
Copy link
Contributor Author

mxinden commented Aug 20, 2020

Looking at the various dashboards (CPU, memory, message count, ...) I can not tell a significant difference between nodes running 0.23 and 0.24 other than the connection count reduction through libp2p/rust-libp2p#1698.

kusama-sentry-ae1-0 and kusama-sentry-ae1-1 have been previously running with libp2p libp2p/rust-libp2p@e32ff74 and are running libp2p 0.24.0 since 2020-08-19 ~11 a.m. CEST.

kusama-sentry-ae1-0 runs with --enable-authority-discovery and thus makes excessive use of the DHT. The two nodes before yesterday 11 a.m. would never be on par in regards to connection count, but instead differ by ~100 connections, ignoring the periodic spikes triggered by authority discovery every 10 minutes. This is gone since libp2p 0.24.0.

image

Wild guess: Might this be related to libp2p/rust-libp2p#1710 which makes libp2p properly pass listen upgrade errors?

Cargo.lock Outdated
"libp2p-core",
"libp2p-core 0.20.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've probably forgotten to update a Cargo.toml somewhere. It seems that we're now using two different versions of libp2p at the same time.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I did a bad merge in 22cb019 not updating the libp2p version introduced in #4954.

@tomaka
Copy link
Contributor

tomaka commented Aug 20, 2020

Please bot merge at your leisure.

@mxinden mxinden removed the A1-needs_burnin Pull request needs to be tested on a live validator node before merge. DevOps is notified via matrix label Aug 21, 2020
@mxinden
Copy link
Contributor Author

mxinden commented Aug 21, 2020

bot merge

@ghost
Copy link

ghost commented Aug 21, 2020

Trying merge.

@ghost ghost merged commit 3f1341a into master Aug 21, 2020
@ghost ghost deleted the mxinden-libp2p-0.24.0 branch August 21, 2020 06:25
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants