Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Remove implementation of Randomness for () #6959

Merged
merged 1 commit into from
Aug 26, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions frame/society/src/mock.rs
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@
use super::*;

use frame_support::{
impl_outer_origin, parameter_types, ord_parameter_types, traits::{OnInitialize, OnFinalize}
impl_outer_origin, parameter_types, ord_parameter_types,
traits::{OnInitialize, OnFinalize, TestRandomness},
};
use sp_core::H256;
use sp_runtime::{
Expand Down Expand Up @@ -99,7 +100,7 @@ impl pallet_balances::Trait for Test {
impl Trait for Test {
type Event = ();
type Currency = pallet_balances::Module<Self>;
type Randomness = ();
type Randomness = TestRandomness;
type CandidateDeposit = CandidateDeposit;
type WrongSideDeduction = WrongSideDeduction;
type MaxStrikes = MaxStrikes;
Expand Down
5 changes: 4 additions & 1 deletion frame/support/src/traits.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1345,7 +1345,10 @@ pub trait Randomness<Output> {
}
}

impl<Output: Decode + Default> Randomness<Output> for () {
/// Provides an implementation of [`Randomness`] that should only be used in tests!
pub struct TestRandomness;

impl<Output: Decode + Default> Randomness<Output> for TestRandomness {
fn random(subject: &[u8]) -> Output {
Output::decode(&mut TrailingZeroInput::new(subject)).unwrap_or_default()
}
Expand Down