This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Add WeightInfo to Babe and Grandpa Pallet
#7155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawntabrizi
added
A0-please_review
shawntabrizi
changed the title
WeightInfo to Babe PalletWeightInfo to Babe and Grandpa Pallet
kianenigma
reviewed
Sep 21, 2020
| // calculate the weight but we set a floor of 100 validators. | ||
| let validator_count = validator_count.max(100) as u64; | ||
|
|
||
| // worst case we are considering is that the given offender |
There was a problem hiding this comment.
@andresilva you should keep an eye on this: https://github.com/paritytech/substrate/issues/6641
TLDR; It is really nonsensical that we store all backers of a validators and slash all of them but reward only a portion of them (top 64). I am considering making this always top 64, so here you can always ensure that MAX_NOMINATORS = 64;
There was a problem hiding this comment.
Good! That way we can drop this assumption and have a strict upper bound on the number of nominators a slash will affect.
kianenigma
approved these changes
Sep 21, 2020
andresilva
approved these changes
Sep 21, 2020
Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com>
|
bot merge |
|
Trying merge. |
ghost
merged commit
rakanalh
pushed a commit
to rakanalh/substrate
that referenced
this pull request
Sep 22, 2020
* Add `WeightInfo` to Babe Pallet * Also grandpa * Update frame/grandpa/src/default_weights.rs Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com> Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com>
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes no logical changes to the Babe or Grandpa Pallet. It simply refactors the custom weight formula into the
WeightInfopattern we have used across the other pallets.polkadot companion: paritytech/polkadot#1736