Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Releasing 2.0 – two dot 😮 #7182

Merged
merged 6 commits into from
Sep 22, 2020
Merged

Releasing 2.0 – two dot 😮 #7182

merged 6 commits into from
Sep 22, 2020

Conversation

gnunicorn
Copy link
Contributor

@gnunicorn gnunicorn commented Sep 22, 2020 •
edited
Loading

as it says on the tin.

fixes #6865

@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Sep 22, 2020
@gnunicorn gnunicorn added the B0-silent Changes should not be mentioned in any release notes label Sep 22, 2020
@gnunicorn gnunicorn changed the title Drafting 2.0 – two point 😮 Drafting 2.0 – two DOT 😮 Sep 22, 2020
@gnunicorn gnunicorn changed the title Drafting 2.0 – two DOT 😮 Drafting 2.0 – two dot 😮 Sep 22, 2020
@gnunicorn gnunicorn added the C1-low PR touches the given topic and has a low impact on builders. label Sep 22, 2020
@gnunicorn gnunicorn changed the title Drafting 2.0 – two dot 😮 Releasing 2.0 – two dot 😮 Sep 22, 2020
@s3krit
Copy link
Contributor

s3krit commented Sep 22, 2020

From a visual overview - LGTM! 👍 🎉 🚀 🥳

s3krit
s3krit approved these changes Sep 22, 2020
View reviewed changes
Copy link
Contributor

@s3krit s3krit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. The skip-checks match could probably be more specific (skip what checks?), but since these jobs only run on master and tags, I don't think we're likely to accidentally have commit messages contain the string 'skip-checks'.

gnunicorn
gnunicorn commented Sep 22, 2020
View reviewed changes
Copy link
Contributor Author

@gnunicorn gnunicorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looked through it again, nothing out of the ordinary. let's go.

@gnunicorn gnunicorn merged commit a200cdb into master Sep 22, 2020
@gnunicorn gnunicorn deleted the ben-releasing-twopointohh branch September 22, 2020 17:47
sorpaas pushed a commit that referenced this pull request Nov 20, 2020
@gnunicorn
Releasing 2.0 – two dot 😮 (#7182)
66da36b 
Tagging the release of substrate 2.0


[ci: skip-checks]
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@s3krit s3krit s3krit approved these changes

@andresilva andresilva Awaiting requested review from andresilva

@kianenigma kianenigma Awaiting requested review from kianenigma

@mxinden mxinden Awaiting requested review from mxinden

@NikVolf NikVolf Awaiting requested review from NikVolf

@pepyakin pepyakin Awaiting requested review from pepyakin

@sorpaas sorpaas Awaiting requested review from sorpaas sorpaas is a code owner

@tomusdrw tomusdrw Awaiting requested review from tomusdrw

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Releasing 2.0 final tracking issue
3 participants
@gnunicorn @s3krit @paritytech-ci