This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
client/network: Stop sending noise legacy handshake #7211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stop sending legacy handshake payloads, i.e. length-prefixed protobuf payloads inside a length-prefixed noise frame. Receiving of such legacy handshakes is still supported, thus backwards compatibility is given.
mxinden
added
A0-please_review
romanb
approved these changes
Sep 25, 2020
|
This pull request has been running on The percentage of filled peer slots is unchanged.
The number of incoming connection errors has increased. While this change looks drastic on the graph below, it is below 100 incoming-handshake errors per 5 minutes. I assume that these errors are due to nodes running Polkadot
Dialing failures are unchanged.
With the above in mind, anyone objecting merging this into |
tomaka
approved these changes
Sep 28, 2020
romanb
approved these changes
Sep 28, 2020
|
bot merge |
|
Trying merge. |
ghost
merged commit
liuchengxu
pushed a commit
to liuchengxu/substrate
that referenced
this pull request
Oct 5, 2020
Stop sending legacy handshake payloads, i.e. length-prefixed protobuf payloads inside a length-prefixed noise frame. Receiving of such legacy handshakes is still supported, thus backwards compatibility is given.
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop sending noise legacy handshake payloads, i.e. length-prefixed protobuf
payloads inside a length-prefixed noise frame. Receiving of such legacy
handshakes is still supported, thus backwards compatibility is given.
Fixes #7175.
Release note suggestion: