Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

client: fix log filters #7241

Merged
2 commits merged into from
Sep 30, 2020
Merged

client: fix log filters #7241

2 commits merged into from
Sep 30, 2020

Conversation

andresilva
Copy link
Contributor

No description provided.

@andresilva andresilva added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Sep 30, 2020
Copy link
Member

@sorpaas sorpaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. Directives only parse a single one. I missed that.

@sorpaas
Copy link
Member

sorpaas commented Sep 30, 2020

I don't think this fixes @shawntabrizi's problem though -- currently, one still has to explicitly pass RUST_LOG=cranelife_wasm=warn to suppress those should-be-by-default-disabled logs. I'm still investigating that.

@sorpaas
Copy link
Member

sorpaas commented Sep 30, 2020

bot merge

@ghost
Copy link

ghost commented Sep 30, 2020

Trying merge.

@ghost ghost merged commit a67de98 into master Sep 30, 2020
@ghost ghost deleted the andre/fix-logger-filters branch September 30, 2020 20:12
liuchengxu pushed a commit to liuchengxu/substrate that referenced this pull request Oct 5, 2020
* client: fix multiple logger filters

* client: add test for log filters setup
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants