This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Add an system_syncState RPC method #7315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaka
added
A0-please_review
tomaka
commented
Oct 13, 2020
client/rpc-api/src/system/helpers.rs
Outdated
| pub highest_block: Option<Number>, | ||
| } | ||
|
|
||
| fn none<T>() -> Option<T> { None } |
There was a problem hiding this comment.
Note: if I try use #[serde(default)] instead, I get a compilation error saying that Number doesn't implement Default, which I don't understand.
tomaka
commented
Oct 13, 2020
| @@ -44,6 +44,7 @@ lazy_static = { version = "1.4.0", optional = true } | |||
| [dev-dependencies] | |||
| assert_matches = "1.3.0" | |||
| futures01 = { package = "futures", version = "0.1.29" } | |||
| lazy_static = "1.4.0" | |||
There was a problem hiding this comment.
cargo test in client/rpc fails to compile without this line.
bkchr
approved these changes
Oct 13, 2020
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
Stefie
approved these changes
Oct 13, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5727
(I don't know who to ask for a review)
Example usage:
The
highestBlockfield will be missing for a short duration after the node starts.