This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
sync: only restart peers not doing finality related requests #7322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresilva
added
A0-please_review
bkchr
reviewed
Oct 14, 2020
|
@bkchr Both done 👍 |
bkchr
approved these changes
Oct 16, 2020
arkpar
approved these changes
Oct 16, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When performing block import we might refuse to import a block until some previous block justifications are imported (#7321). With the current implementation we will restart the sync process after getting a block import error. In this case, we will drop all in-flight sync requests and figure out new block requests for each peer. This leads to a situation where we are constantly restarting sync and are unable to download the justifications that would eventually fix the block import error. This PR changes the sync logic so that when restarting it peers that were doing any kind of finality related request (downloading justifications or finality proofs) keep their existing state.