Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Allow where clause in decl_error! #7324

Merged
1 commit merged into from
Oct 14, 2020
Merged

Allow where clause in decl_error! #7324

1 commit merged into from
Oct 14, 2020

Conversation

gui1117
Copy link
Contributor

@gui1117 gui1117 commented Oct 14, 2020

If a trait has some where clause then decl_error will fail to compile.

This PR solve it by allowing decl_error to specify some where clause.

@gui1117 gui1117 requested review from bkchr and kianenigma October 14, 2020 15:07
@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Oct 14, 2020
@gui1117 gui1117 added B3-apinoteworthy C1-low PR touches the given topic and has a low impact on builders. labels Oct 14, 2020
@gui1117 gui1117 changed the title Allow where clause in decl_error Allow where clause in decl_error! Oct 14, 2020
@kianenigma
Copy link
Contributor

If this can be supported, then I am all happy.

https://github.com/paritytech/substrate/pull/7319/files#diff-608450c398dfbce477973170a09cfd3f8394baea48114e147fb093582135b15dR400-R409

I'll try and test it with this branch later, you can try the same for sanity.

@bkchr
Copy link
Member

bkchr commented Oct 14, 2020

bot merge

@ghost
Copy link

ghost commented Oct 14, 2020

Waiting for commit status.

@ghost ghost merged commit eb66745 into master Oct 14, 2020
@ghost ghost deleted the gui-decl_error-where-clause branch October 14, 2020 15:39
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants