This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
client/authority-discovery: Remove sentry node logic #7368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The notion of sentry nodes has been deprecated (see [1] for details). This commit removes support for sentry nodes in the `client/authority-discovery` module. While removing `Role::Sentry` this commit also introduces `Role::Discover`, allowing a node to discover addresses of authorities without publishing ones own addresses. This will be needed in Polkadot for collator nodes. [1] paritytech#6845
mxinden
added
A0-please_review
ordian
reviewed
Oct 21, 2020
ordian
approved these changes
Oct 22, 2020
|
bot merge |
|
Missing process info; check that the PR belongs to a project column. Merge can be attempted if:
See https://github.com/paritytech/parity-processbot#faq |
@tomaka could you give this pull request a review as well? |
tomaka
approved these changes
Oct 26, 2020
|
bot merge |
|
Trying merge. |
ghost
merged commit
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The notion of sentry nodes has been deprecated (see [1] for details).
This commit removes support for sentry nodes in the
client/authority-discoverymodule.While removing
Role::Sentrythis commit also introducesRole::Discover, allowing a node to discover addresses of authoritieswithout publishing ones own addresses. This will be needed in Polkadot
for collator nodes (//CC @ordian).
polkadot companion: paritytech/polkadot#1835
[1] #6845
Release note suggestion: