Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Use inbound peerslot slots when a substream is received, rather than a connection #7464

Merged
42 commits merged into from
Nov 16, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
f6a190b
Use inbound peerslot slots when a substream is received, rather than …
tomaka Oct 27, 2020
72b9955
Refactor PeerState
tomaka Oct 29, 2020
4182faf
Some bugfixes
tomaka Oct 30, 2020
6026894
Fix warnings so that CI runs, gmlrlblbl
tomaka Oct 30, 2020
856abcf
Bugfixes
tomaka Nov 2, 2020
e6f5569
Update docs
tomaka Nov 2, 2020
be64e75
Apply suggestions from code review
tomaka Nov 3, 2020
b0caa7c
Clean up Banned state
tomaka Nov 3, 2020
ca95b8b
Merge remote-tracking branch 'upstream/master' into fix-7074
tomaka Nov 4, 2020
9cb2388
Refactor connections state
tomaka Nov 4, 2020
b045aa6
Fix possibility of Enabled with no Opening or Open connection
tomaka Nov 4, 2020
5e9e6ad
Line width
tomaka Nov 4, 2020
7b8636b
Add some debug_asserts! and fix TODO
tomaka Nov 4, 2020
3fa8fb8
Merge remote-tracking branch 'upstream/master' into fix-7074
tomaka Nov 4, 2020
29cb9cf
Refactor legacy handler
tomaka Nov 5, 2020
d035be1
Rewrite group.rs entirely [part 1]
tomaka Nov 6, 2020
8513430
Rewrite group.rs entirely [part 2]
tomaka Nov 11, 2020
8fd2ae1
Merge remote-tracking branch 'upstream/master' into fix-7074
tomaka Nov 11, 2020
470ef2c
Remove faulty assertion
tomaka Nov 12, 2020
b46016f
Don't poll the legacy substream is not Open
tomaka Nov 12, 2020
b2018a6
Tolerate when not all substreams are accepted
tomaka Nov 12, 2020
797fb49
Remove TODOs
tomaka Nov 12, 2020
259ddd7
Dummy commit to make CI log interesting things
tomaka Nov 12, 2020
0675c65
Try race condition fix
tomaka Nov 12, 2020
c522ec5
Revert "Try race condition fix"
tomaka Nov 12, 2020
57a0042
Correctly rebuild pending_opening
tomaka Nov 12, 2020
2ee20de
Minor tweaks
tomaka Nov 12, 2020
e7852a2
Printlns for CI debugging
tomaka Nov 12, 2020
639a83c
Revert "Printlns for CI debugging"
tomaka Nov 12, 2020
55bd87f
Revert "Dummy commit to make CI log interesting things"
tomaka Nov 12, 2020
2de8105
mv group.rs ../handler.rs
tomaka Nov 12, 2020
1e5cd4f
Apply suggestions from code review
tomaka Nov 13, 2020
556ab6f
Banned => Backoff
tomaka Nov 13, 2020
0e5f130
Mention the actual PeerStates
tomaka Nov 13, 2020
ca31ed3
OpenDesired -> OpenDesiredByRemote
tomaka Nov 13, 2020
7578c9e
OpeningThenClosing
tomaka Nov 13, 2020
3c4ed8f
Add doc links to PeerState
tomaka Nov 13, 2020
61fc5bb
Simplify increment logic
tomaka Nov 13, 2020
222fee2
One more debug_assert
tomaka Nov 13, 2020
4d90970
debug_assert!
tomaka Nov 13, 2020
9d3c981
OpenDesiredByRemote
tomaka Nov 13, 2020
ae87242
Update client/network/src/protocol/generic_proto/behaviour.rs
tomaka Nov 16, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions client/network/src/protocol.rs
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ pub mod message;
pub mod event;
pub mod sync;

pub use generic_proto::{NotificationsSink, Ready, NotifsHandlerError, LegacyConnectionKillError};
pub use generic_proto::{NotificationsSink, Ready, NotifsHandlerError};

const REQUEST_TIMEOUT_SEC: u64 = 40;
/// Interval at which we perform time based maintenance
Expand Down Expand Up @@ -1668,7 +1668,7 @@ impl<B: BlockT, H: ExHashT> NetworkBehaviour for Protocol<B, H> {
notifications_sink,
}
},
GenericProtoOut::CustomProtocolClosed { peer_id, .. } => {
GenericProtoOut::CustomProtocolClosed { peer_id } => {
self.on_peer_disconnected(peer_id)
},
GenericProtoOut::LegacyMessage { peer_id, message } =>
Expand Down
2 changes: 1 addition & 1 deletion client/network/src/protocol/generic_proto.rs
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
//! network, then performs the Substrate protocol handling on top.

pub use self::behaviour::{GenericProto, GenericProtoOut};
pub use self::handler::{NotifsHandlerError, NotificationsSink, Ready, LegacyConnectionKillError};
pub use self::handler::{NotifsHandlerError, NotificationsSink, Ready};

mod behaviour;
mod handler;
Expand Down
1,672 changes: 1,149 additions & 523 deletions client/network/src/protocol/generic_proto/behaviour.rs

Large diffs are not rendered by default.

1,055 changes: 1,041 additions & 14 deletions client/network/src/protocol/generic_proto/handler.rs

Large diffs are not rendered by default.

Loading