Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

minor fix and improvements on localkeystore #7626

Merged
4 commits merged into from
Dec 1, 2020
Merged

minor fix and improvements on localkeystore #7626

4 commits merged into from
Dec 1, 2020

Conversation

gnunicorn
Copy link
Contributor

This removes pub a bunch of internal methods of LocalKeystore, adds a test for local-keystore to only hold but then drop keys generated with a seed (as the trait docs define it) and then a fix that actually does that.

separated from ##7365

@gnunicorn gnunicorn added A0-please_review Pull request needs code review. B5-clientnoteworthy C1-low PR touches the given topic and has a low impact on builders. labels Nov 30, 2020
@gnunicorn gnunicorn changed the title minor fixes and improvements on localkeystore minor fixe and improvements on localkeystore Nov 30, 2020
@gnunicorn gnunicorn changed the title minor fixe and improvements on localkeystore minor fix and improvements on localkeystore Nov 30, 2020
bkchr
bkchr approved these changes Nov 30, 2020
View reviewed changes
client/keystore/src/local.rs Outdated Show resolved Hide resolved
wheresaddie
wheresaddie approved these changes Nov 30, 2020
View reviewed changes
Copy link
Contributor

@wheresaddie wheresaddie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @gnunicorn

rakanalh
rakanalh approved these changes Nov 30, 2020
View reviewed changes
Copy link
Contributor

@rakanalh rakanalh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

client/keystore/src/local.rs Show resolved Hide resolved
@gnunicorn
Copy link
Contributor Author

bot merge

@ghost
Copy link

ghost commented Dec 1, 2020

Waiting for commit status.

@ghost
Copy link

ghost commented Dec 1, 2020

Checks failed; merge aborted.

@gnunicorn
Copy link
Contributor Author

bot merge

@ghost
Copy link

ghost commented Dec 1, 2020

Waiting for commit status.

@ghost ghost merged commit cbe1cc3 into master Dec 1, 2020
@ghost ghost deleted the ben-minor-keystore-fixes branch December 1, 2020 14:35
darkfriend77 pushed a commit to mogwaicoin/substrate that referenced this pull request Jan 11, 2021
@gnunicorn @darkfriend77
minor fix and improvements on localkeystore (paritytech#7626)
002a330 
* minor fixes and improvements on localkeystore

* fixing tests

* update docs
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bkchr bkchr bkchr approved these changes

@wheresaddie wheresaddie wheresaddie approved these changes

@rakanalh rakanalh rakanalh approved these changes

@seunlanlege seunlanlege Awaiting requested review from seunlanlege

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gnunicorn @rakanalh @wheresaddie @bkchr