-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Issue 6904 first free council vote #7632
Issue 6904 first free council vote #7632
Conversation
Hello Shawn, Like to do quick check on implementation approach for the issue. In above Demo test sequence, able the detect the first-time voters. But looking for some clarity on balance transaction. |
Hello Shawn, Thanks for guidance, reverted pallet-democracy changes. Used below logic to detect the first vote within a proposal. And verified with testcase "tests::motions_revoting_works()" [slightly modified] ... From below trace account 2 is detected as first vote in a proposal ... Note:: Plz ignore changes in "frame/democracy/src/tests.rs", Some mistake in my cleanup ... will correct it :-) |
Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
Hello Shawn, Moved the "mod test" to tests.rs Introduced new test case "motions_all_first_vote_free_works()" to validate the changes ... looks like I am messing up in testing for Pay::Yes & Pay::No For Ok condition I am using assert_eq!() pattern And for Err case I am using match {} pattern, due to enum Err() members are quite high ... Or is it better to use assert_eq!() here also ? Plz suggest best alternate ... |
Plz Ignore this PR, instead use PR | 7661 |
Beta implementation to resolve the issue Participating in Governance should be Free for First Time Voters #6904
First level of demo sequence