-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Conversation
@ascjones Do you know how we should handle the deprecation of |
we can also have a deprecated alias. This could help other to migrate. before this PR raw event was:
Maybe we can now do:
But at the same time this is a breaking RawEvent as its generic are different |
Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>
…ssets-to-new-procmacro
Right, so people would get a compiler error and also the deprecation message? That seems good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
bot merge |
Trying merge. |
@thiolliere I added the |
Yes I think it is better to have all the commit with potential need for migration labelled as such. It is useful for other builders |
Converts the Assets pallet to the new pallet attribute macro introduced in #6877.
Part of #7882.
Upgrade guidelines used.
From https://crates.parity.io/frame_support/attr.pallet.html#checking-upgrade-guidelines
So users of the
Assets
pallet must be careful about the name they used inconstruct_runtime!
. Hence theruntime-migration
label, which might not be needed depending on the configuration of theAssets
pallet.