-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Conversation
…tech/substrate into na-remote-ext-jsonrpsee-show-kian
…lly-migration-testing-2' into na-remote-ext-jsonrpsee-show-kian
…lly-migration-testing-2' into na-remote-ext-jsonrpsee-show-kian
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
…tech/substrate into na-remote-ext-jsonrpsee-show-kian
Waht's the prospect of this? |
After paritytech/jsonrpsee#215 is merged, I plan to publish an alpha release for the clients |
@@ -101,9 +101,13 @@ | |||
//! } | |||
//! ``` | |||
|
|||
// jsonrpsee_proc_macros generates faulty warnings: https://github.com/paritytech/jsonrpsee/issues/106 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be good if you provide follow ups for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's fixed on master but I haven't done another release yet :)
…te-ext-jsonrpsee-show-kian
uri: "http://localhost:9933".into(), | ||
uri: TARGET.to_owned(), | ||
rpc: Arc::new( | ||
HttpClient::new( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is wrong -- We can't initialize the client here. Then, if we override the at
later, if will be a noop. Will push fixes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(or maybe it is correct -- have to check)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, I didn't understand that thanks for the fix.
bot merge |
Waiting for commit status. |
Head SHA changed; merge aborted. |
bot merge |
Waiting for commit status. |
Fixes #8038 (comment) which replaces
jsonrpc-core-client
withjsonrpsee-http-client
and doesn't requiretokio 0.1