This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Rework telemetry to replace the use of tracing with an object we pass around #8143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cecton
force-pushed
the
cecton-rework-telemetry
branch
from
01900c0
to
5fbc85c
Compare
bkchr
reviewed
Mar 5, 2021
client/telemetry/src/lib.rs
Outdated
| /// Instantiate a new [`TelemetryWorker`] which can run in background. | ||
| /// | ||
| /// Only one is needed per process. | ||
| pub fn new(buffer_size: usize, transport: Option<ExtTransport>) -> Result<Self> { |
There was a problem hiding this comment.
Maybe we could add a second method with_transport where we can pass the transport. Normally we don't need this.
maciejhirsz
approved these changes
Mar 5, 2021
|
@maciejhirsz @bkchr can you also validate the polkadot part? |
|
Done |
|
bot merge |
|
Checks failed; merge aborted. |
cecton
added a commit
to paritytech/polkadot
that referenced
this pull request
Mar 11, 2021
HCastano
added a commit
to paritytech/parity-bridges-common
that referenced
this pull request
Apr 6, 2021
Related Substrate PR: paritytech/substrate#8143
HCastano
added a commit
to paritytech/parity-bridges-common
that referenced
this pull request
Apr 7, 2021
* Bump Substrate * Change usage of "Module" to "Pallet" Related Substrate PR: paritytech/substrate#8372 * Add `OnSetCode` config param Related Substrate PR: paritytech/substrate#8496 * Update Aura Slot duration time type Related Substrate PR: paritytech/substrate#8386 * Add `OnSetCode` to mock runtimes * Add support for multiple justifications Related Substrate PR: paritytech/substrate#7640 * Use updated justification type in more places * Make GenesisConfig type non-optional Related Substrate PR: paritytech/substrate#8275 * Update service to use updated telemetry Related Substrate PR: paritytech/substrate#8143 * Appease Clippy
jordy25519
pushed a commit
to cennznet/substrate
that referenced
this pull request
Sep 17, 2021
… around (paritytech#8143) polkadot companion: paritytech/polkadot#2535
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
polkadot companion: paritytech/polkadot#2535