This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
grandpa: maintain invariants when evaluating aggregated voting rules #8186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresilva
added
A0-please_review
bkchr
approved these changes
Feb 23, 2021
|
bot merge |
|
Checks failed; merge aborted. |
|
bot merge force |
|
Trying merge. |
|
Merge failed: |
octol
approved these changes
Feb 28, 2021
|
|
|
bot merge force |
|
Trying merge. |
ghost
merged commit
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Voting rules can only restrict the result in the range
[base, current_target], e.g. if they return some block lower than base then the result should be discard. Implementations of voting rules should keep this invariant but now it is enforced when evaluating multiple voting rules.