Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Fix tests in phragmen election pallet #8211

Merged
merged 1 commit into from
Mar 2, 2021
Merged

Fix tests in phragmen election pallet #8211

merged 1 commit into from
Mar 2, 2021

Conversation

gui1117
Copy link
Contributor

@gui1117 gui1117 commented Feb 26, 2021

If I do:

		assert!(matches!(
				unwrapped_error.post_info.actual_weight,
				Some(x) if x < <Test as frame_system::Config>::BlockWeights::get().max_block
			));

if fails, thus I just assert that there is some refund.

@gui1117 gui1117 requested a review from kianenigma February 26, 2021 12:37
@gui1117 gui1117 added A0-please_review Pull request needs code review. A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Feb 26, 2021
@gui1117 gui1117 mentioned this pull request Feb 26, 2021
Closed
@bkchr bkchr merged commit 0a85d36 into master Mar 2, 2021
@bkchr bkchr deleted the gui-fix-useless-matches branch March 2, 2021 18:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kianenigma kianenigma kianenigma approved these changes

@bkchr bkchr bkchr approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gui1117 @kianenigma @bkchr @paritytech-ci