This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Fix ignored error in benchmark tests #8214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gui1117
added
A0-please_review
shawntabrizi
approved these changes
Feb 26, 2021
bkchr
approved these changes
Feb 26, 2021
jam10o-new
pushed a commit
to jam10o-new/substrate
that referenced
this pull request
Feb 28, 2021
* fix ignored error in benchmark tests * use normal format for str * explicit match Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if a benchmark fails and return error (instead of panicking) then the test ignores it.
That might worth a frame-benchmarking 3.1.1 release.