This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
im-online: use EstimateNextSessionRotation to get better estimates of session progress #8242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresilva
added
A0-please_review
|
I still need to add tests for this but wanted to get an initial validation of the approach. Namely that it may be too expensive to calculate a rational value for this when we're only interested in doing a check |
andresilva
commented
Mar 2, 2021
gui1117
reviewed
Mar 2, 2021
gui1117
reviewed
Mar 2, 2021
gui1117
approved these changes
Mar 2, 2021
kianenigma
reviewed
Mar 11, 2021
kianenigma
reviewed
Mar 11, 2021
|
Ahh, and, is it possible to write a test for this in im-online? |
|
Updated with everything that was suggested. Please approve the companion as well :) |
|
bot merge force |
|
Trying merge. |
ghost
merged commit
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently im-online relies on the session duration to value to calculate the block at which the session is halfway through. When using BABE the session duration is defined in slots (not blocks), as such this method can lead to a high error in the estimate if a lot of slots are skipped. This PR adds a new method
estimate_current_session_progressto theEstimateNextSessionRotationtrait and makes the im-online pallet use it.polkadot companion: paritytech/polkadot#2602