This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Make ExecuteBlock::execute_block return the final block header
#8244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pr changes the `ExecuteBlock` trait to return the final header that results from executing the given block.
bkchr
added
A0-please_review
bkchr
added a commit
to paritytech/polkadot
that referenced
this pull request
Mar 2, 2021
gui1117
approved these changes
Mar 2, 2021
shawntabrizi
approved these changes
Mar 3, 2021
|
bot merge force |
|
Trying merge. |
ghost
merged commit
ghost
pushed a commit
to paritytech/polkadot
that referenced
this pull request
Mar 3, 2021
* Companion for `ExecuteBlock` changes in Substrate paritytech/substrate#8244 * "Update Substrate" Co-authored-by: parity-processbot <>
kianenigma
reviewed
Mar 3, 2021
| /// # Panic | ||
| /// | ||
| /// Panics when an extrinsics panics or the resulting header doesn't match the expected header. | ||
| fn execute_block(block: Block) -> Block::Header; |
There was a problem hiding this comment.
doesn't the block already include a header, where it is equal to the one being returned?
There was a problem hiding this comment.
Yeah you are right. I also thought about this yesterday and than I thought that I had found something that requires this, but after thinking about this again, I do not require to return the header here. :(
ggwpez
pushed a commit
to ggwpez/runtimes
that referenced
this pull request
Mar 10, 2023
* Companion for `ExecuteBlock` changes in Substrate paritytech/substrate#8244 * "Update Substrate" Co-authored-by: parity-processbot <>
ggwpez
pushed a commit
to ggwpez/runtimes
that referenced
this pull request
Jul 13, 2023
* Companion for `ExecuteBlock` changes in Substrate paritytech/substrate#8244 * "Update Substrate" Co-authored-by: parity-processbot <>
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr changes the
ExecuteBlocktrait to return the final header thatresults from executing the given block.
polkadot companion: paritytech/polkadot#2548