Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

AuRa improvements #8255

Merged
merged 4 commits into from
Mar 5, 2021
Merged

AuRa improvements #8255

merged 4 commits into from
Mar 5, 2021

Conversation

bkchr
Copy link
Member

@bkchr bkchr commented Mar 3, 2021

Hot and fresh AuRa improvements. This pr does the following:

  • Move code belonging to the import queue etc to import_queue.rs
  • Introduce ImportQueueParams and StartAuraParams structs to make
    it more easier to understand what parameters we pass to AuRa.
  • Introduce CheckForEquivocation to tell AuRa if it should check for
    equivocation on block import. This is required for parachains, because
    they are allowed to equivocate when they build two blocks for the same
    slot, but for different relay chain parents.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Hot and fresh AuRa improvements. This pr does the following:

- Move code belonging to the import queue etc to import_queue.rs
- Introduce `ImportQueueParams` and `StartAuraParams` structs to make
it more easier to understand what parameters we pass to AuRa.
- Introduce `CheckForEquivocation` to tell AuRa if it should check for
equivocation on block import. This is required for parachains, because
they are allowed to equivocate when they build two blocks for the same
slot, but for different relay chain parents.
@bkchr bkchr added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Mar 3, 2021
@bkchr bkchr requested review from andresilva and octol March 3, 2021 15:56
Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com>
Copy link
Contributor

@octol octol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

config.prometheus_registry(),
sp_consensus::NeverCanAuthor,
let import_queue = sc_consensus_aura::import_queue::<AuraPair, _, _, _, _, _>(
ImportQueueParams {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah :D TY

@bkchr bkchr merged commit 79ddc79 into master Mar 5, 2021
@bkchr bkchr deleted the bkchr-aura-further-improvements branch March 5, 2021 16:03
jordy25519 pushed a commit to cennznet/substrate that referenced this pull request Sep 17, 2021
* AuRa improvements

Hot and fresh AuRa improvements. This pr does the following:

- Move code belonging to the import queue etc to import_queue.rs
- Introduce `ImportQueueParams` and `StartAuraParams` structs to make
it more easier to understand what parameters we pass to AuRa.
- Introduce `CheckForEquivocation` to tell AuRa if it should check for
equivocation on block import. This is required for parachains, because
they are allowed to equivocate when they build two blocks for the same
slot, but for different relay chain parents.

* Update client/consensus/aura/src/import_queue.rs

Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com>

* Fix compilation

* AAA

Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants