This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Finish removing support for legacy network protocol #8296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaka
added
A0-please_review
|
Deploying the PR has brought up a new kind of disconnect reason:
(the red and violet peaks on the right aren't present on the left side) However this is very minor and I suggest to not worry about these old nodes. |
|
Nothing unusual on the burnin node. |
|
Needs a second approval for merging. |
|
bot merge force |
|
Trying merge. |
|
Merge failed: |
bkchr
approved these changes
Mar 11, 2021
|
bot merge |
|
Checks failed; merge aborted. |
|
bot merge force |
|
Trying merge. |
ghost
merged commit 
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #5670
The so-called legacy network protocol was already half-non-functioning. We broke its features over time, such as performing block requests and sending transactions. The reason why it wasn't completely removed earlier is because older versions still open this substream for handshaking purposes, even though they don't make use of it once it's open.
This PR finishes removing it entirely.
The changes were very straight forward. It is purely code removal.
It seems that Rust does not always properly warn about unused code, as it didn't warn me about the
upgrade::legacymodule being unused even though it was. There might be more old code that can be removed, but I don't know where.