This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Expose block number in seal_random #8329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
athei
added
A0-please_review
Can you elaborate on this change in design? |
Updated the initial post. |
athei
added
the
D3-trivial 🧸
gui1117
approved these changes
Mar 23, 2021
athei
added
D2-notlive 💤
|
ink! |
|
bot merge |
|
Missing approval from the project owner or a minimum of core developers. Merge can be attempted if:
See https://github.com/paritytech/parity-processbot#faq |
Robbepop
approved these changes
Mar 23, 2021
|
bot merge |
|
Trying merge. |
ghost
merged commit
hirschenberger
pushed a commit
to hirschenberger/substrate
that referenced
this pull request
Apr 14, 2021
* Allow contract callable functions to specify the module * Add new version of `seal_random` * Fix overlong lines * Fix benchmarking code * Update README.md * Replace Module by Pallet
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8297
seal_random(by scoping it underseal1) that returns the block number in addition to the seedIn the long term we should convert
define_env!to a proc macro. This stuff is becoming ugly.The new contract callable function has the same name
seal_randombut is scoped under another wasm module. The module of the function isseal1in contrast to the old moduleseal0that hosts the original function.@Robbepop ink! should switch to the new interface and make the block number available to its users. It is not a breaking change, though. The old version remains to be supported indefinitely.