This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
alerting-rules: ContinuousTaskEnded alert shouldn't drop unspecified labels #8369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabreal
added
A0-please_review
s3krit
approved these changes
Mar 16, 2021
rcny
approved these changes
Mar 16, 2021
hirschenberger
pushed a commit
to hirschenberger/substrate
that referenced
this pull request
Apr 14, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the
-operators and specifying matching labels with theonkeyword all other labels are being dropped. This breaks some custom alert routing where additional labels are made use of.This can be prevented with adding the generic
group_left()parameter which basically defines which label set to take from as a base.ref: https://prometheus.io/docs/prometheus/latest/querying/operators/