Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Better description for assert in frame-session genesis #8399

Merged
merged 2 commits into from
Mar 18, 2021

Conversation

bkchr
Copy link
Member

@bkchr bkchr commented Mar 18, 2021

There is an assert that checks that an account exists, after setting a
key. However, this assert isn't very self-descriptive.

There is an assert that checks that an account exists, after setting a
key. However, this assert isn't very self-descriptive.
@bkchr bkchr added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Mar 18, 2021
@bkchr bkchr added the D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit label Mar 18, 2021
Copy link
Contributor

@gui1117 gui1117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>
@bkchr bkchr merged commit 4365fa6 into master Mar 18, 2021
@bkchr bkchr deleted the bkchr-session-genesis-better-error branch March 18, 2021 19:24
hirschenberger pushed a commit to hirschenberger/substrate that referenced this pull request Apr 14, 2021
* Better description for assert in frame-session genesis

There is an assert that checks that an account exists, after setting a
key. However, this assert isn't very self-descriptive.

* Update frame/session/src/lib.rs

Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>

Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants