Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

CI: address the bug with .env #8404

Merged
merged 1 commit into from
Mar 22, 2021
Merged

CI: address the bug with .env #8404

merged 1 commit into from
Mar 22, 2021

Conversation

TriplEight
Copy link
Contributor

to properly trigger Simnet.
Also, add TRIGGERER for more grained pipelines there.

@TriplEight TriplEight added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Mar 19, 2021
@TriplEight TriplEight self-assigned this Mar 19, 2021
@TriplEight TriplEight requested a review from a team as a code owner March 19, 2021 14:31
@TriplEight TriplEight added the D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit label Mar 19, 2021
@bkchr bkchr removed the D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit label Mar 19, 2021
@TriplEight TriplEight requested review from rcny, s3krit and bkchr March 19, 2021 16:24
@TriplEight
Copy link
Contributor Author

@bkchr this label was needed to start gitlab CI

@bkchr
Copy link
Member

bkchr commented Mar 20, 2021

What does the trivial label starts?

@shawntabrizi
Copy link
Member

@bkchr the trivial label is for PRs which do not require an audit

@bkchr
Copy link
Member

bkchr commented Mar 21, 2021

@bkchr the trivial label is for PRs which do not require an audit

I know, I requested the label. However, @TriplEight said this label started a special ci job and I want to know which.

This pr doesn't need the trivial label as it doesn't touch anything runtime related and the bot not enforcing it.

@TriplEight
Copy link
Contributor Author

@bkchr now, without D* label, GitLab CI jobs won't start.

@TriplEight TriplEight merged commit 97da79e into master Mar 22, 2021
@TriplEight TriplEight deleted the 3x8_fix_env_for_trigger branch March 22, 2021 11:02
hirschenberger pushed a commit to hirschenberger/substrate that referenced this pull request Apr 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants