Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Use Debug for genesis mismatch message #8449

Merged
merged 1 commit into from
Mar 24, 2021
Merged

Use Debug for genesis mismatch message #8449

merged 1 commit into from
Mar 24, 2021

Conversation

tomaka
Copy link
Contributor

@tomaka tomaka commented Mar 24, 2021

This message is important enough to use DEBUG instead of TRACE.

@tomaka tomaka added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Mar 24, 2021
@bkchr
Copy link
Member

bkchr commented Mar 24, 2021

We already print this as warning when it is important. Why should we print for normal (random) peers that they are on a different genesis? When do we need this for debugging?

@tomaka
Copy link
Contributor Author

tomaka commented Mar 24, 2021

I don't understand your objection. If we went through the source code to remove all the log entries that aren't useful for debugging, we could remove half of the code base.
Right now nodes will fail to connect, and in every single situation the reason is printed in the logs with either DEBUG, INFO or WARN, apart from this one.

bkchr
bkchr approved these changes Mar 24, 2021
View reviewed changes
Copy link
Member

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay fine.

@andresilva
Copy link
Contributor

bot merge

@ghost
Copy link

ghost commented Mar 24, 2021

Waiting for commit status.

@bkchr bkchr merged commit 3efe87d into paritytech:master Mar 24, 2021
@tomaka tomaka deleted the genesis-mismatch-debug branch March 24, 2021 21:09
hirschenberger pushed a commit to hirschenberger/substrate that referenced this pull request Apr 14, 2021
@tomaka @hirschenberger
Use Debug for genesis mismatch message (paritytech#8449)
2c7462d
jordy25519 pushed a commit to cennznet/substrate that referenced this pull request Sep 17, 2021
@tomaka @jordy25519
Use Debug for genesis mismatch message (paritytech#8449)
024fbcd
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andresilva andresilva andresilva approved these changes

@bkchr bkchr bkchr approved these changes

Assignees
No one assigned
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomaka @bkchr @andresilva