This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
ModuleId to PalletId - part of #8372
#8477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kianenigma
added
A0-please_review
kianenigma
reviewed
Mar 29, 2021
gui1117
approved these changes
Mar 29, 2021
Maybe it should be moved to frame-support, I don't know why it is in primitives considering client doesn't need it. |
|
Yeah @AurevoirXavier please move |
Where should I place it? Currently I place it on the frame-support's root (lib.rs) |
|
root is ok to me, but compilation needs to be fixed |
On the way. Also a companion for polkadot. |
bkchr
approved these changes
Mar 30, 2021
|
@thiolliere I also change the subcommand |
AurevoirXavier
force-pushed
the
xavier-pallet-id
branch
from
c177e1d
to
36eb978
Compare
bkchr
approved these changes
Apr 7, 2021
|
@AurevoirXavier this requires a polkadot companion. |
Done |
shawntabrizi
approved these changes
Apr 9, 2021
|
bot merge |
|
Trying merge. |
ghost
merged commit 
hirschenberger
pushed a commit
to hirschenberger/substrate
that referenced
this pull request
Apr 14, 2021
* `ModuleId` to `PalletId` - part of paritytech#8372 * fix doc * move `PalletId` to `frame-support` * fix compile * fix tests * `ModuleId` to `PalletId` * subcommand `moduleid` to `palletid`
jordy25519
pushed a commit
to cennznet/substrate
that referenced
this pull request
Sep 20, 2021
* `ModuleId` to `PalletId` - part of paritytech#8372 * fix doc * move `PalletId` to `frame-support` * fix compile * fix tests * `ModuleId` to `PalletId` * subcommand `moduleid` to `palletid`
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #8372
Polkadot companion: paritytech/polkadot#2835
@thiolliere