Clean test runner up #8485
Clean test runner up #8485
Conversation
seunlanlege
added
A2-insubstantial
Co-authored-by: Andronik Ordian <write@reusable.software>
|
hey @kianenigma @gnunicorn could you please take a look at this? |
| if let Some(base) = std::env::var("DB_BASE_PATH").ok() { | ||
| BasePath::new(base) | ||
| } else { | ||
| BasePath::new_temp_dir().expect("couldn't create a temp dir") |
There was a problem hiding this comment.
Isn't this like a random path?
There was a problem hiding this comment.
yeah, it is, if you don't supply an existing db path, it is assumed you want to test with a new db
There was a problem hiding this comment.
yeah okay I was wondering if loading a fresh DB would make any sense, but yeah I presume you could also start with a new DB and it should be fine.
|
bump |
1 similar comment
|
bump |
| @@ -71,6 +81,89 @@ impl ChainInfo for NodeTemplateChainInfo { | |||
| ) | |||
| } | |||
|
|
|||
| fn config(task_executor: TaskExecutor) -> Configuration { | |||
There was a problem hiding this comment.
why can't this stay in utils/test-runner? I was happy that in the previous PR you made it such, but why is it being reverted now?
I still think that 80% of the things being configured here are pretty irrelevant to the end user/programmer, thus not a good API.
There was a problem hiding this comment.
At least we can provide different variations where you have fn config() as it is now, and a config_default() or something like this.
There was a problem hiding this comment.
There are cases where we'd like to run the test runner as a bin and provide it with command line args like a real node. (This is all simnet stuff), yeah i suppose a default would be nice 🤔
* bump scale-codec in test runner * refactor config * Update test-utils/test-runner/Cargo.toml Co-authored-by: Andronik Ordian <write@reusable.software> * bump cargo.lock * add reasonable defaults Co-authored-by: Andronik Ordian <write@reusable.software>
This just bumps
parity-scale-codecin test-runner tov2