This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Fix account ref-counting in session #8538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavofyork
added
A0-please_review
gavofyork
assigned shawntabrizi and kianenigma and unassigned shawntabrizi and kianenigma
shawntabrizi
reviewed
Apr 6, 2021
shawntabrizi
approved these changes
Apr 6, 2021
kianenigma
approved these changes
Apr 6, 2021
|
bot merge |
|
Trying merge. |
ghost
merged commit
hirschenberger
pushed a commit
to hirschenberger/substrate
that referenced
this pull request
Apr 14, 2021
* Fix account ref-counting in session. * Avoid needless check * fix compile * put back in check and conversion * Fix test to actually catch this error Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
jakoblell
added
D1-audited 👍
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #8536