Update Identity pallet to Frame V2 #8697
Conversation
|
| let sender = ensure_signed(origin)?; | ||
| let sub = T::Lookup::lookup(sub)?; | ||
| ensure!(IdentityOf::<T>::contains_key(&sender), Error::<T>::NoIdentity); | ||
| ensure!(SuperOf::<T>::get(&sub).map_or(false, |x| x.0 == sender), Error::<T>::NotOwned); | ||
| SuperOf::<T>::insert(&sub, (sender, data)); | ||
| Ok(()) | ||
| } | ||
|
|
There was a problem hiding this comment.
Not sure why new macro wanted me to add dispatch.
Just wanted to highlight to make sure this is sensible and not incorrect
There was a problem hiding this comment.
yes new macro doesn't accept to return nothing, we could enhance the macro though
There was a problem hiding this comment.
no, lets make returns explicit. less macro magic :)
|
Kusama and Polkadot both have Identity in |
|
/benchmark runtime pallet pallet_identity |
|
Error running benchmark: pallet-identity-framev2 stdoutfatal: ambiguous argument 'origin/pallet-identity-framev2': unknown revision or path not in the working tree. Use '--' to separate paths from revisions, like this: 'git [...] -- [...]' |
|
@ferrell-code not compiling? |
shawntabrizi
added
B0-silent
|
oops my bad forgot to push, should be good now :) |
|
/benchmark runtime pallet pallet_identity |
|
Error running benchmark: pallet-identity-framev2 stdoutfatal: ambiguous argument 'origin/pallet-identity-framev2': unknown revision or path not in the working tree. Use '--' to separate paths from revisions, like this: 'git [...] -- [...]' |
| let sender = ensure_signed(origin)?; | ||
| let sub = T::Lookup::lookup(sub)?; | ||
| ensure!(IdentityOf::<T>::contains_key(&sender), Error::<T>::NoIdentity); | ||
| ensure!(SuperOf::<T>::get(&sub).map_or(false, |x| x.0 == sender), Error::<T>::NotOwned); | ||
| SuperOf::<T>::insert(&sub, (sender, data)); | ||
| Ok(()) | ||
| } | ||
|
|
There was a problem hiding this comment.
yes new macro doesn't accept to return nothing, we could enhance the macro though
gui1117
added
B3-apinoteworthy
and removed
B0-silent
Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>
|
bot merge |
|
Trying merge. |
ghost
merged commit 
* bump pallet to frame v2 * line width * get benchmarking ot compile * fix benchmarking now * should actually fix benchmark * make docs prettier * add dependency * add metadata * Update frame/identity/src/benchmarking.rs Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com> Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com> Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>
Updated Identity pallet to Frame V2 🍣
relates #7882